[FLINK-38552] [Helm] Fix FlinkStateSnapshot when operator's namespace not in watchNamespaces #1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this fix, @MaksimAniskov This check was added when introducing FlinkStateSnapshot in release 1.10 to make sure that we don't break existing deployments where the CRD is not yet installed by creating a controller. I think it should be safe to remove this check altogether in the next release of 1.14, so the Helm chart change might not even be needed. WDYT? |
|
@mateczagany I saw that isCrdInstalled is scheduled for deleting. If the check gets deleted, that will solve the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes support for FlinkStateSnapshot CRDs getting disabled if the operator deployed using the Helm chart and the operator's namespace not listed in watchNamespaces value.
The operator's isCrdInstalled check requires list permission for flinkstatesnaphots verb in the operator's namespace.
When the namespace listed in watchNamespaces, lines 24-32 of helm/flink-kubernetes-operator/templates/rbac/role.yaml create the Kubernetes role with necessary permission as defined in helm/flink-kubernetes-operator/templates/rbac/_helpers.tpl
When the operator's namespace isn't in watchNamespaces, another part of the template defines the role. This part should also define the permission.